fix GitHub windows workflows - #310
Conversation
1146d71 to
cda8d98
Compare
lefessan
added
the
GIT ONLY NO SVN
cda8d98 to
c2cf10a
Compare
| # this no longer seems necessary today | ||
| # PATH="$PATH:/c/Program Files/Git/usr/bin" | ||
| ../configure $CFGOPT CFLAGS=-std=c17 | ||
| ../configure $CFGOPT CFLAGS=-std=gnu17 LDFLAGS=-lintl |
There was a problem hiding this comment.
I still would like to understand what we need LDFLAGS=-lintl for - and if we can set that to something more specific (the global ones will "leak" into cobc calls).
| - name: Adjust testsuite | ||
| run: | | ||
| rem Skip test as it sometimes works and sometimes not... | ||
| rem %MSYS_BASH% -lc "sed -i '/used_binaries/{N;/temporary path invalid/{N;N;N;N;s/traceon/traceon; echo \"workflow:1\">\"$at_check_line_file\"; at_fn_check_skip 77/;}}' tests/testsuite" | ||
|
|
||
| rem Change to expected fail if there's an error specific to the CI that we don't want to change | ||
| rem in the testsuite for expected result (should normally only be a temporary thing) | ||
| rem sed -i '/run_fundamental/{N;/Compare FLOAT-LONG with floating-point literal/{N;s/at_xfail=no/at_xfail=yes/;}}' tests/testsuite | ||
|
|
There was a problem hiding this comment.
That just doesn't do anything (same as before)... if possible I'd like to keep it in (but commenting out the step completely) in case we need to ignore something for some time on Win32 (for example during longer development of a feature/fix where "works outside of Windows" is something we may even commit upstream)
(same applies to the change in the other workflow)
|
The CI is currently working well on Windows, so I am not sure this PR is still useful... |
|
Asa the rest of this PR (originally it contained more) only deletes comments + add LDFLAGS that seem to not be used (+switches to gnu standard isntead of iso, which enables some other features), I suggest to close this and directly change c17 to gnu17 (no PR needed), |
|
one single remark on the MSVC Debug builds originally pointed out in the obsolete #257;
|
2 participants
This commit comes from #303 , to separate between changes in GnuCOBOL SVN, and changes specific to the GIT repository. It is supposed to be merged into .gitside-gnucobol-3.x after branch 303 has been committed into SVN.